From 201410de60405148a8ae1e0bad568a9879fc06a8 Mon Sep 17 00:00:00 2001 From: Mario Sanchez Prada Date: Thu, 16 May 2013 15:34:05 +0100 Subject: [PATCH] Missing NULL-check in XI2's implementation for get_window() Add missing check in gdk_x11_device_manager_xi2_get_window(), returning NULL if no valid XI2Event* has been found. Calling code seems to be prepared to handle NULLs coming from this function, so it should be safe enough (e.g. check gdk_event_source_get_filter_window()). https://bugzilla.gnome.org/show_bug.cgi?id=700465 --- gdk/x11/gdkdevicemanager-xi2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdk/x11/gdkdevicemanager-xi2.c b/gdk/x11/gdkdevicemanager-xi2.c index 751343a122..b9093b9089 100644 --- a/gdk/x11/gdkdevicemanager-xi2.c +++ b/gdk/x11/gdkdevicemanager-xi2.c @@ -1682,6 +1682,8 @@ gdk_x11_device_manager_xi2_get_window (GdkEventTranslator *translator, return NULL; ev = (XIEvent *) xevent->xcookie.data; + if (!ev) + return NULL; get_event_window (translator, ev, &window); return window; -- 2.30.2